3.5 KiB
Coding Standards
C is a dangerous language by itself, plus tinyusb make use of goodies features of C99, which saves a tons of code lines (also means save a tons of bugs). However, those features can be misused and pave the way for bugs sneaking into. Therefore, to minimize bugs, the author try to comply with published Coding Standards like:
Where is possible, standards are followed but it is almost impossible to follow all of these without making some exceptions. I am pretty sure this code base violates more than what are described below, if you can find any, please report it to me or file an issue on github.
MISRA-C 2004 Exceptions
MISRA-C is well respected & a bar for industrial coding standard.
-
Rule 2.2: use only
It has long passed the day that C99 comment style // will cause any issues, especially compiler's C99 mode is required to build tinyusb.
-
Rule 8.5: No definitions of objects or function in a header file
function definitions in header files are used to allow 'inlining'
-
Rule 14.7: A function shall have a single point of exit at the end of the function
Unfortunately, following this rule will have a lot of nesting if-else, I prefer to exit as soon as possible with assert style and flatten if-else.
-
Rule 18.4: Unions shall not be used
sorry MISRA, union is required to effectively mapped to MCU's registers
-
expect to have more & more exceptions.
Power of 10
is a small & easy to remember but yet powerful coding guideline. Most (if not all) of the rules here are included in JPL. Because it is very small, all the rules will be listed here, those with italic are compliant, bold are violated.
-
Restrict to simple control flow constructs
yes, I hate goto statement, therefore there is none of those here
-
Give all loops a fixed upper-bound
one of my favorite rule
-
Do not use dynamic memory allocation after initialization
the tinyusb uses the static memory for all of its data.
-
Limit functions to no more than 60 lines of text
60 is a little bit too strict, I will update the relaxing number later
-
Use minimally two assertions per function on average
not sure the exact number, but I use a tons of those assert
-
Declare data objects at the smallest possible level of scope
one of the best & easiest rule to follow
-
Check the return value of non-void functions, and check the validity of function parameters
I did check all of the public application API's parameters. For internal API, calling function needs to trust their caller to reduce duplicated check.
-
Limit the use of the preprocessor to file inclusion and simple macros
Although I prefer inline function, however C macros are far powerful than that. I simply cannot hold myself to use, for example X-Macro technique to simplify code.
-
Limit the use of pointers. Use no more than two levels of dereferencing per expression
never intend to get in trouble with complex pointer dereferencing.
-
Compile with all warnings enabled, and use one or more source code analyzers
I try to use all the defensive options of gnu, let me know if I miss some.
-Wextra -Wswitch-default -Wunsafe-loop-optimizations -Wcast-align -Wlogical-op -Wpacked-bitfield-compat -Wnested-externs -Wredundant-decls -Winline
JPL
coming soon ...