From 799584a21095dc188143a6b6ee4726456f83d813 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?King=20K=C3=A9vin?= Date: Wed, 15 Sep 2021 17:48:40 +0200 Subject: [PATCH] esp8266: minor, fix spacing --- lib/radio_esp8266.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/lib/radio_esp8266.c b/lib/radio_esp8266.c index 08cdbd6..6f5fc1a 100644 --- a/lib/radio_esp8266.c +++ b/lib/radio_esp8266.c @@ -51,8 +51,8 @@ static void radio_esp8266_transmit(uint8_t* data, uint8_t length) { } usart_disable_tx_interrupt(USART(RADIO_ESP8266_USART)); // ensure transmit interrupt is disable to prevent index corruption (the ISR should already have done it) radio_esp8266_activity = false; // reset status because of new activity - for (tx_used=0; tx_used0) { + if (command_length > 0) { radio_esp8266_transmit((uint8_t*)command, command_length); // transmit AT command while (!radio_esp8266_activity || !radio_esp8266_success) { // wait for response __WFI(); // sleep until something happened @@ -140,26 +140,26 @@ void radio_esp8266_close(void) /** USART interrupt service routine called when data has been transmitted or received */ void USART_ISR(RADIO_ESP8266_USART)(void) { - if (usart_get_interrupt_source(USART(RADIO_ESP8266_USART), USART_SR_TXE)) { // data has been transmitted + if (usart_get_flag(USART(RADIO_ESP8266_USART), USART_SR_TXE)) { // data has been transmitted if (tx_used) { // there is still data in the buffer to transmit - usart_send(USART(RADIO_ESP8266_USART),tx_buffer[tx_used-1]); // put data in transmit register + usart_send(USART(RADIO_ESP8266_USART), tx_buffer[tx_used - 1]); // put data in transmit register tx_used--; // update used size } else { // no data in the buffer to transmit usart_disable_tx_interrupt(USART(RADIO_ESP8266_USART)); // disable transmit interrupt } } - if (usart_get_interrupt_source(USART(RADIO_ESP8266_USART), USART_SR_RXNE)) { // data has been received - while (rx_used>=LENGTH(rx_buffer)) { // if buffer is full - memmove(rx_buffer,&rx_buffer[1],LENGTH(rx_buffer)-1); // drop old data to make space (ring buffer are more efficient but harder to handle) + if (usart_get_flag(USART(RADIO_ESP8266_USART), USART_SR_RXNE)) { // data has been received + while (rx_used >= LENGTH(rx_buffer)) { // if buffer is full + memmove(rx_buffer, &rx_buffer[1], LENGTH(rx_buffer) - 1); // drop old data to make space (ring buffer are more efficient but harder to handle) rx_used--; // update used buffer information } rx_buffer[rx_used++] = usart_recv(USART(RADIO_ESP8266_USART)); // put character in buffer // if the used send a packet with these strings during the commands detection the AT command response will break (AT commands are hard to handle perfectly) - if (rx_used>=4 && memcmp((char*)&rx_buffer[rx_used-4], "OK\r\n", 4)==0) { // OK received + if (rx_used >= 4 && 0 == memcmp((char*)&rx_buffer[rx_used-4], "OK\r\n", 4)) { // OK received radio_esp8266_activity = true; // response received radio_esp8266_success = true; // command succeeded rx_used = 0; // reset buffer - } else if (rx_used>=7 && memcmp((char*)&rx_buffer[rx_used-7], "ERROR\r\n", 7)==0) { // ERROR received + } else if (rx_used >= 7 && 0 == memcmp((char*)&rx_buffer[rx_used-7], "ERROR\r\n", 7)) { // ERROR received radio_esp8266_activity = true; // response received radio_esp8266_success = false; // command failed rx_used = 0; // reset buffer